[lkml]   [2008]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRE: [regression] Latest git has WARN_ON storm with e1000e driver

    On Fri, 3 Oct 2008, Brandeburg, Jesse wrote:
    > Linus Torvalds wrote:
    > > So this whole bug is actually because that debug test is just
    > > _broken_. It shouldn't be WARN_ON(preempt_count()), it should be
    > > 'might_sleep()', which does it right.
    > >
    > > The right thing to check is "in_atomic() || irqs_disabled()".
    > okay, do you want me to post a patch? I think Thomas is probably
    > offline due to fridaynightitis. Change the code to:?
    > WARN_ON(in_atomic() || irqs_disabled);

    No, literally just "might_sleep()". It then does everything right,
    including taking into account that we allow certain behavior during bootup
    that we don't allow later.


     \ /
      Last update: 2008-10-03 18:39    [W:0.021 / U:1.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site