lkml.org 
[lkml]   [2008]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: Re: [PATCH 3/6] memcg: charge-commit-cancel protocl
    ----- Original Message -----
    >> precharge/commit/cancel can be used for other places,
    >> - shmem, (and other places need precharge.)
    >> - move_account(force_empty) etc...
    >> we'll revisit later.
    >>
    >> Changelog v5 -> v6:
    >> - added newpage_charge() and migrate_fixup().
    >> - renamed functions for swap-in from "swap" to "swapin"
    >> - add more precise description.
    >>
    >
    >I don't have any objection to this direction now, but I have one quiestion.
    >
    >Does mem_cgroup_charge_migrate_fixup need to charge a newpage,
    >while mem_cgroup_prepare_migration has charged it already?
    In migration-is-failed case, we have to charge *old page* here.

    >
    >I agree adding I/F would be good for future, but I think
    >mem_cgroup_charge_migration_fixup can be no-op function for now.
    >
    Hmm, handling failure case in explicit way may be better. Ok,
    I'll try some.

    Thanks,
    -Kame




    \
     
     \ /
      Last update: 2008-10-03 17:19    [W:0.025 / U:30.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site