Messages in this thread Patch in this message | | | Date | Fri, 3 Oct 2008 00:56:07 -0400 | From | Mathieu Desnoyers <> | Subject | [PATCH] x86 Topology cpu_to_node parameter check |
| |
Declare NUMA-less cpu_to_node with a check that the cpu parameter exists so people without NUMA test configs (namely Steven Rostedt and myself who ran into this error both in the same day with different implementations) stop doing this trivial mistake.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Steven Rostedt <rostedt@goodmis.org> CC: Linus Torvalds <torvalds@linux-foundation.org> CC: Peter Zijlstra <peterz@infradead.org> CC: Andrew Morton <akpm@linux-foundation.org> CC: Ingo Molnar <mingo@elte.hu> --- include/asm-x86/topology.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6-lttng/include/asm-x86/topology.h =================================================================== --- linux-2.6-lttng.orig/include/asm-x86/topology.h 2008-10-03 00:37:05.000000000 -0400 +++ linux-2.6-lttng/include/asm-x86/topology.h 2008-10-03 00:45:52.000000000 -0400 @@ -182,9 +182,9 @@ extern int __node_distance(int, int); #else /* !CONFIG_NUMA */ -#define numa_node_id() 0 -#define cpu_to_node(cpu) 0 -#define early_cpu_to_node(cpu) 0 +#define numa_node_id() 0 +#define cpu_to_node(cpu) ((void)(cpu),0) +#define early_cpu_to_node(cpu) cpu_to_node(cpu) static inline const cpumask_t *_node_to_cpumask_ptr(int node) { -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |