lkml.org 
[lkml]   [2008]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: two trivial sparse annotations

* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> arch/x86/kernel/vsmp_64.c:87:14: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/vsmp_64.c:87:14: expected void const volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:87:14: got void *[assigned] address
> arch/x86/kernel/vsmp_64.c:88:22: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/vsmp_64.c:88:22: expected void const volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:88:22: got void *
> arch/x86/kernel/vsmp_64.c:100:23: warning: incorrect type in argument 2 (different address spaces)
> arch/x86/kernel/vsmp_64.c:100:23: expected void volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:100:23: got void *
> arch/x86/kernel/vsmp_64.c:101:23: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/vsmp_64.c:101:23: expected void const volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:101:23: got void *
> arch/x86/mm/gup.c:235:6: warning: incorrect type in argument 1 (different base types)
> arch/x86/mm/gup.c:235:6: expected void const volatile [noderef] <asn:1>*<noident>
> arch/x86/mm/gup.c:235:6: got unsigned long [unsigned] [assigned] start
>
> Impact: fewer sparse warnings, no functional changes
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/x86/kernel/vsmp_64.c | 2 +-
> arch/x86/mm/gup.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

applied to tip/x86/urgent, thanks Harvey!

i see you started using the impact-line, nice :) I moved it to the top
of the commit, that's where we generally put it. (it acts as a
secondary subject line in essence, so sits right next to the first
line of the commit)

Ingo


\
 
 \ /
  Last update: 2008-10-29 08:07    [W:0.049 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site