lkml.org 
[lkml]   [2008]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Capabilities: BUG when an invalid capability is requested
On Wed, 29 Oct 2008 11:42:12 -0400
Eric Paris <eparis@redhat.com> wrote:

> If an invalid (large) capability is requested the capabilities system
> may panic as it is dereferencing an array of fixed (short) length.
> Its possible (and actually often happens) that the capability system
> accidentally stumbled into a valid memory region but it also regularly
> happens that it hits invalid memory and BUGs. If such an operation
> does get past cap_capable then the selinux system is sure to have
> problems as it already does a (simple) validity check and BUG. This
> is known to happen by the broken and buggy firegl driver.
>
> This patch cleanly checks all capable calls and BUG if a call is for
> an invalid capability. This will likely break the firegl driver for
> some situations, but it is the right thing to do. Garbage into a
> security system gets you killed/bugged
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
>

Acked-by: Arjan van de Ven <arjan@linux.intel.com>


\
 
 \ /
  Last update: 2008-10-29 16:51    [W:0.304 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site