Messages in this thread | | | Date | Tue, 28 Oct 2008 09:29:20 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] LOCKDEP: minor fix for debug_show_all_locks() |
| |
* sniper <s3c24xx@gmail.com> wrote:
> When we failed to get tasklist_lock eventually (count equals 0), > we should only print " ignoring it.\n", and not print > " locked it.\n" needlessly.
well spotted!
Minor nit:
> --- a/kernel/lockdep.c > +++ b/kernel/lockdep.c > @@ -3417,10 +3417,12 @@ retry: > } > printk(" ignoring it.\n"); > unlock = 0; > + goto print_locks; > } > if (count != 10) > printk(" locked it.\n"); > > +print_locks: > do_each_thread(g, p) {
please move the "if (count != 10)" line into the else section of the trylock, instead of introducing a label and a goto.
Ingo
| |