lkml.org 
[lkml]   [2008]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] regression: vmalloc easily fail.
    Date
    Commit db64fe02258f1507e13fe5212a989922323685ce broke
    KVM (the symptom) for me. The cause is that vmalloc
    allocations fail, despite of the fact that /proc/meminfo
    shows plenty of vmalloc space available.

    After some investigation, it seems to me that the current
    way to compute the next addr in the rb-tree transversal
    leaves a spare page between each allocation. After a few
    allocations, regardless of their size, we run out of vmalloc
    space.

    Signed-off-by: Glauber Costa <glommer@redhat.com>
    Cc: Jeremy Fitzhardinge <jeremy@goop.org>
    Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
    ---
    mm/vmalloc.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/mm/vmalloc.c b/mm/vmalloc.c
    index 0365369..a33b0d1 100644
    --- a/mm/vmalloc.c
    +++ b/mm/vmalloc.c
    @@ -363,7 +363,7 @@ retry:
    }

    while (addr + size >= first->va_start && addr + size <= vend) {
    - addr = ALIGN(first->va_end + PAGE_SIZE, align);
    + addr = ALIGN(first->va_end, align);

    n = rb_next(&first->rb_node);
    if (n)
    --
    1.5.6.5


    \
     
     \ /
      Last update: 2008-10-28 22:01    [W:0.019 / U:0.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site