lkml.org 
[lkml]   [2008]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] Implement generic freeze feature
On Mon, 27 Oct 2008 21:58:54 +0900 Takashi Sato <t-sato@yk.jp.nec.com> wrote:

> -void thaw_bdev(struct block_device *bdev, struct super_block *sb)
> +int thaw_bdev(struct block_device *bdev, struct super_block *sb)
> {
> + int error = 0;
> +
> + mutex_lock(&bdev->bd_fsfreeze_mutex);
> + if (!bdev->bd_fsfreeze_count) {
> + mutex_unlock(&bdev->bd_fsfreeze_mutex);
> + return -EINVAL;

This would be a programming error, yes?

If so, a WARN_ON is more appropriate than a silent runtime error.

> + }


\
 
 \ /
  Last update: 2008-10-28 07:19    [W:0.060 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site