Messages in this thread | | | Date | Tue, 28 Oct 2008 12:18:05 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [patch 3/7] mm: make page writeback obey cpuset constraints |
| |
On Tue, 28 Oct 2008, Peter Zijlstra wrote:
> > + is_subset = cpuset_populate_dirty_limits(dl, &dirtyable_memory, > > + &nr_mapped, nodes); > > + if (!is_subset) { > > + dl->nr_dirty = global_page_state(NR_FILE_DIRTY); > > + dl->nr_unstable = global_page_state(NR_UNSTABLE_NFS); > > + dl->nr_writeback = global_page_state(NR_WRITEBACK); > > + dirtyable_memory = determine_dirtyable_memory(); > > + nr_mapped = global_page_state(NR_FILE_MAPPED) + > > + global_page_state(NR_ANON_PAGES); > > + } else > > + dirtyable_memory -= highmem_dirtyable_memory(nodes, > > + dirtyable_memory); > > Why not fold that all into cpuset_populate_dirty_limits() ? >
cpuset_populate_dirty_limits() is a no-op on !CONFIG_CPUSETS kernels.
| |