Messages in this thread | | | Subject | Re: [RFC PATCH 3/5] net/ipv4, net/ipv6: use %#p6, %p6 format strings | From | Joe Perches <> | Date | Mon, 27 Oct 2008 22:05:38 -0700 |
| |
On Mon, 2008-10-27 at 21:05 -0700, Harvey Harrison wrote: > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index eea9542..113c4d9 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -2986,9 +2986,8 @@ static void if6_seq_stop(struct seq_file *seq, void *v) > static int if6_seq_show(struct seq_file *seq, void *v) > { > struct inet6_ifaddr *ifp = (struct inet6_ifaddr *)v; > - seq_printf(seq, > - NIP6_SEQFMT " %02x %02x %02x %02x %8s\n", > - NIP6(ifp->addr), > + seq_printf(seq, "%#p6 %02x %02x %02x %02x %8s\n", > + &ifp->addr, > ifp->idev->dev->ifindex, > ifp->prefix_len, > ifp->scope,
Is it really necessary to change the formats and arguments?
Perhaps it's enough to change the defines to:
#define NIP6_FMT "%6p" #define NIP6_SEQFMT "%#6p" #define NIP6(addr) &(addr)
If not, I think the NIP6 and NIP6_SEQFMT should be separate patchsets for ease of verification.
| |