lkml.org 
[lkml]   [2008]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] linux/timex.h: cleanup for userspace
    On Sun, 26 Oct 2008 06:37:31 -0400 Mike Frysinger <vapier@gentoo.org> wrote:

    > Move all the kernel-specific defines and includes into the __KERNEL__
    > section so that they don't get leaked into userspace.
    >

    checkpatch correctly instructs us to use linux/param.h, not asm/param.h.

    This:

    --- a/include/linux/timex.h~linux-timexh-cleanup-for-userspace-checkpatch-fixes
    +++ a/include/linux/timex.h
    @@ -165,8 +165,8 @@ struct timex {
    #ifdef __KERNEL__
    #include <linux/compiler.h>
    #include <linux/types.h>
    +#include <linux/param.h>

    -#include <asm/param.h>
    #include <asm/timex.h>

    /*
    _
    seems Obviously Safe to me. Do you agree?

    (please use checkpatch - sometimes it's useful!)


    \
     
     \ /
      Last update: 2008-10-28 04:31    [W:0.022 / U:32.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site