lkml.org 
[lkml]   [2008]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH] ftrace: Add a C/P state tracer to help power optimization
On Mon, 27 Oct 2008 15:47:30 -0400
fche@redhat.com (Frank Ch. Eigler) wrote:

>
> Arjan van de Ven <arjan@infradead.org> writes:
>
> > [...]
> > --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> > +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> > [...]
> > @@ -427,6 +429,8 @@ static int acpi_cpufreq_target(struct
> > cpufreq_policy *policy, }
> > }
> >
> > + trace_power_mark(&it, POWER_PSTATE, next_perf_state);
> > +
> > switch (data->cpu_feature) {
> > case SYSTEM_INTEL_MSR_CAPABLE:
> > cmd.type = SYSTEM_INTEL_MSR_CAPABLE;
> > [...]
>
> Is there some reason that this doesn't use tracepoints instead
> of such a single-backend hook?

because it's a ton simpler this way? do simple things simpe and all
that....

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2008-10-27 22:09    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site