lkml.org 
[lkml]   [2008]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] SGI x86 UV: Update SCIR driver to use idle_cpu function

* Mike Travis <travis@sgi.com> wrote:

> Subject: SGI x86 UV: Update SCIR driver to use idle_cpu function
>
> > Please send the cpu_idle() cleanup patch separately.
>
> Change UV heartbeat function to use idle_cpu to determine cpu's
> "idleness". Realign uv_hub definitions.
>
> Signed-of-by: Mike Travis <travis@sgi.com>
> ---
> arch/x86/include/asm/uv/uv_hub.h | 26 +++++++++++++-------------
> arch/x86/kernel/genx2apic_uv_x.c | 4 ++--
> 2 files changed, 15 insertions(+), 15 deletions(-)

applied to tip/x86/uv, thanks Mike!

one small comment:

> + /* is this cpu idle? */
> + if (idle_cpu(smp_processor_id()))
> bits &= ~SCIR_CPU_ACTIVITY;

were you ever to run an -rt kernel on that hardware, this would
produce a warning. raw_smp_processor_id() would be more appropriate i
guess.

Ingo


\
 
 \ /
  Last update: 2008-10-27 19:09    [W:0.176 / U:0.400 seconds]
©2003-2014 Jasper Spaans. Advertise on this site