Messages in this thread | | | Date | Sat, 25 Oct 2008 16:14:56 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH RESEND] vgacon: remember scrollback buffer on console switch |
| |
On Sun, 26 Oct 2008 00:43:01 +0200 Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> PS: why DECLARE_MUTEX _defines_ _semaphore_?
The kernel gets definition-vs-declaration confused in several places.
> there are only 8 uses of this > macro so it's not a big problem to rename it to e.g. DEFINE_SEMAPHORE (I can > provide a patch)
I'd say that s/declare/define/ at such a late stage in the semaphore's lifetime would be of dubious value. But getting "MUTEX" out of that macro's name would be a very good thing - it's a bad overlap with struct mutex. Send patch :)
| |