Messages in this thread | | | Date | Sat, 25 Oct 2008 13:36:53 -0700 | From | walt <> | Subject | Re: commit a802dd0e breaks console keyboard input |
| |
Heiko Carstens wrote: > On Fri, Oct 24, 2008 at 04:13:59PM -0700, walt wrote: >>> Please try the patch below. It basically reverts the whole stop_machine >>> patches. That way we should know if it really comes from the moved init >>> call or if it is some other weird bug. I would have expected more bug >>> reports if the stop_machine patches would be broken. Hmmm... >> <second patch snipped for brevity> >> >> Yes your second patch fixes the keyboard problem, thanks. The lack of >> other complainers is what made me think of a BIOS bug, but that's just >> wild guesswork on my part. I'm happy to keep trying patches if you can >> keep making them :-) > > Thanks a lot for testing and your patience! > The patch below moves the init call to its old place but makes the > stop_machine initialization happen later. I added a BUG_ON to catch possible > early calls, but there shouldn't be any. I think the patch should solve > the regression you are seeing. Could you give it a try please? > The patch applies on top of latest Linus' git tree...
<patch snipped for brevity> Yes, everything seems back to normal with this patch, thanks.
| |