Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH -tip/cpus4096-v2] cpumask: fix memory leak and cpumask corruption | Date | Fri, 24 Oct 2008 19:55:29 +1100 |
| |
On Friday 24 October 2008 15:59:59 Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Hi Hiroshi,
Thanks for looking at this!
> On CONFIG_CPUMASK_OFFSTACK enabled kernel, when exiting > smp_call_function_many() without calling arch_send_call_function_ipi() > allbutself should be freed.
That bit's OK, changing the return to "goto out;".
> Also, the memory for allbutself shouldn't be freed when > arch_send_call_function_ipi() is called. The memory region will be > referenced in generic_smp_call_function_interrupt(). And the memory > will be freed at rcu_free_call_data().
As your next patch shows, this should be solved a different way. I'll comment there.
Cheers, Rusty.
| |