lkml.org 
[lkml]   [2008]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -tip/cpus4096-v2] cpumask: fix memory leak and cpumask corruption
Date
On Friday 24 October 2008 15:59:59 Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Hi Hiroshi,

Thanks for looking at this!

> On CONFIG_CPUMASK_OFFSTACK enabled kernel, when exiting
> smp_call_function_many() without calling arch_send_call_function_ipi()
> allbutself should be freed.

That bit's OK, changing the return to "goto out;".

> Also, the memory for allbutself shouldn't be freed when
> arch_send_call_function_ipi() is called. The memory region will be
> referenced in generic_smp_call_function_interrupt(). And the memory
> will be freed at rcu_free_call_data().

As your next patch shows, this should be solved a different way. I'll comment
there.

Cheers,
Rusty.


\
 
 \ /
  Last update: 2008-10-24 10:57    [W:0.033 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site