Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [bug] Re: [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask | Date | Fri, 24 Oct 2008 10:01:53 +1100 |
| |
On Thursday 23 October 2008 23:55:29 Ingo Molnar wrote: > ok, the new cpumask code blew up in -tip testing, with various sorts of > slab corruptions during scheduler init: ... > i suspect it's due to: > > 01b8bd9: sched: cpumask: get rid of boutique sched.c allocations, use > cpumask_va
Just drop it. It's a conversion, so it doesn't really belong in this "new API" stuff. Nothing depends on it, and we need to be sure it's that which is causing the blowup.
Oh, and here's (one) problem:
*nodemask = node_to_cpumask(cpu_to_node(i));
This is an old-style cpumask_t assigment, but nodemask wasn't allocated NR_CPUS bits if CONFIG_CPUMASK_OFFSTACK. This is why assignment is banned (and will eventually fail compile), but that conversion hasn't been done on sched.c yet, so this patch is ahead of its time.
Thanks, Rusty.
| |