Messages in this thread | | | Date | Thu, 23 Oct 2008 14:24:52 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for 2.6.27-rc1) |
| |
On Thu, 23 Oct 2008, Andrew Morton wrote: > > Given that all highmem-implementing archtiectures must use the same > declaration here, we might as well put it into include/linux/highmem.h. > Although that goes against current mistakes^Wcode. > > Does powerpc32 still implement highmem? It seems that way. You broke > it, no?
This really shouldn't be in highmem.h AT ALL.
The whole point of that function has absolutely nothing to do with highmem, and it *must* be useful on non-highmem configurations to be appropriate.
So I'd much rather create a new <linux/kmap.h> or something. Or just expose this from to <asm/fixmap.h> or something. Let's not confuse this with highmem, even if the implementation _historically_ was due to that.
Linus
| |