Messages in this thread | | | Date | Thu, 23 Oct 2008 00:48:15 -0600 | From | Grant Grundler <> | Subject | Re: [PATCH] pci: show dma_mask bits in /sys |
| |
On Wed, Oct 22, 2008 at 06:45:10PM -0700, Yinghai Lu wrote: > Grant prefer to add it /sys instead of showing in bootlog > > so could catch if the driver set the correct dma_mask. > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > --- > drivers/pci/pci-sysfs.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > Index: linux-2.6/drivers/pci/pci-sysfs.c > =================================================================== > --- linux-2.6.orig/drivers/pci/pci-sysfs.c > +++ linux-2.6/drivers/pci/pci-sysfs.c > @@ -169,6 +169,21 @@ numa_node_show(struct device *dev, struc > #endif > > static ssize_t > +dma_mask_bits_show(struct device *dev, struct device_attribute *attr, char *buf) > +{ > + struct pci_dev *pdev = to_pci_dev(dev); > + > + return sprintf (buf, "%d\n", fls64(pdev->dma_mask));
Is there any reason to use %d instead of "0x%x" ? I'd much rather see this dumped in hex.
> +} > + > +static ssize_t > +consistent_dma_mask_bits_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + return sprintf (buf, "%d\n", fls64(dev->coherent_dma_mask)); > +} > + > +static ssize_t > msi_bus_show(struct device *dev, struct device_attribute *attr, char *buf) > { > struct pci_dev *pdev = to_pci_dev(dev); > @@ -223,6 +238,8 @@ struct device_attribute pci_dev_attrs[] > #ifdef CONFIG_NUMA > __ATTR_RO(numa_node), > #endif > + __ATTR_RO(dma_mask_bits), > + __ATTR_RO(consistent_dma_mask_bits), > __ATTR(enable, 0600, is_enabled_show, is_enabled_store), > __ATTR(broken_parity_status,(S_IRUGO|S_IWUSR), > broken_parity_status_show,broken_parity_status_store),
Otherwise looks good to me.
thanks, grant
| |