lkml.org 
[lkml]   [2008]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls
    Date
    On Wednesday 22 October 2008, Anton Vorontsov wrote:
    > --- a/drivers/gpio/pcf857x.c
    > +++ b/drivers/gpio/pcf857x.c
    > @@ -187,7 +187,7 @@ static int pcf857x_probe(struct i2c_client *client,
    >         struct pcf857x                  *gpio;
    >         int                             status;
    >  
    > -       pdata = client->dev.platform_data;
    > +       pdata = pcf857x_get_pdata(client);
    >         if (!pdata)
    >                 return -ENODEV;
    >  

    I suppose that can work. Regardless, some OF-specific code will
    need to map device tree state into a generic format that's fully
    decoupled from OF. (And there's something to be said to having
    that mapping sit in the same directory as the driver needing it.)


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-10-23 08:17    [W:0.021 / U:60.420 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site