Messages in this thread | | | Date | Wed, 22 Oct 2008 17:22:21 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms |
| |
On Mon, 20 Oct 2008 23:43:44 -0400 "Theodore Ts'o" <tytso@mit.edu> wrote:
> + i = le32_to_cpu(es->s_flags); > + if (i & EXT2_FLAGS_UNSIGNED_HASH) > + sbi->s_hash_unsigned = 3; > + else if ((i & EXT2_FLAGS_SIGNED_HASH) == 0) { > + char c; > + > + c = (char) 255; > + if (((int) c) == -1) {
arm says
fs/ext3/super.c: In function `ext3_fill_super': fs/ext3/super.c:1750: warning: comparison is always false due to limited range of data type
Also, is there any way in which this new code can be, umm, cleaned up?
| |