| Date | Wed, 22 Oct 2008 14:55:44 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH 03/11] ftrace: return error on failed modified text. |
| |
On Wed, 22 Oct 2008, Steven Rostedt wrote: > - break; > - } > + ret = ftrace_modify_code(ip, call, nop); > + if (ret) { > + WARN_ON_ONCE(1); > + pr_info("ftrace failed to modify "); > + print_ip_sym(ip); > + print_ip_ins(" expected: ", call); > + print_ip_ins(" replace: ", nop); > + printk(KERN_CONT "\n"); > + break;
This break is an error. I refreshed it in patch 5/11 by mistake.
-- Steve
> > rec->flags |= FTRACE_FL_FAILED; > return 0; > > -- > >
|