Messages in this thread | | | Date | Wed, 22 Oct 2008 11:45:55 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [RFC] SLUB - define OO_ macro instead of hardcoded numbers |
| |
On Wed, 22 Oct 2008, Cyrill Gorcunov wrote:
> Looks really good for me (if it worth anything). But Christoph > doesn't OO_SHIT inspired by u16 too which means we could use > MAX_OBJ_PER_PAGE in form you mentoined but maybe we should define > > #define OO_SHIFT bits_in(page.objects) to point out why we use > 16 not 14, not 18 or whatever? How do you think?
The choice of the bit size in page.objects is determined by the available bytes there. The choice of the OO_SHIFT (nice typo there) is determined by the use of a 32bit int that we want to cut into two halves.
| |