Messages in this thread | | | Date | Wed, 22 Oct 2008 20:41:11 +0200 | From | Manfred Spraul <> | Subject | Re: [PATCH, RFC] v7 scalable classic RCU implementation |
| |
Paul E. McKenney wrote: > Only once per such CPU every grace period -- seems in the noise to me. > But I should revisit, as I have changed things quite a bit since I > made that decision many weeks ago. ;-) > > Another small point: Does your implementation support rcu_check_callbacks() with cpu != smp_processor_id()? I don't think my locking would support it properly. Thus: - cpu != smp_processor_id() doesn't work. - stack space for a useless parameter. - the explicit cpu parameter prevents the rcu code from using get_cpu_var().
What about modifying the rcu_check_callbacks() prototype? I'd propose to remove the cpu parameter.
-- Manfred
| |