Messages in this thread | | | Date | Tue, 21 Oct 2008 23:11:33 -0400 | From | "Mike Frysinger" <> | Subject | Re: [RFC] CRIS: Move header files from include to arch/cris |
| |
On Tue, Oct 21, 2008 at 22:36, Bryan Wu wrote: > Mike Frysinger wrote: >> On Tue, Oct 21, 2008 at 12:42, Jesper Nilsson wrote: >>> That means that the machine dependent header files are moved to >>> arch/cris/mach-{fs,a3}/include, while the common and architecture >>> dependent files are moved to arch/cris/include. >>> >>> It is mainly this I'd like some input on, since most other ports >>> that have moved their header files have put all headers in >>> arch/*/include. >> >> that seems like a fairly obvious good idea to me ... i'm thinking we >> should do it for Blackfin as well ... > > For moving machine header files to arch/blackfin/include/asm/mach-bf{527, > 533, 537, 538, 548, 561}, we need to set a link such as > arch/blackfin/include/asm/mach -> arch/blackfin/include/asm/mach-bf527, > because tons of drivers use the header file <asm/mach/xxxx.h>.
i dont think a ton of drivers use asm/mach/xxx.h considering how few files we have in there. a transition would be pretty trivial.
> But we don't like to setup a link that is the one reason we move our header > file from include/asm-blackfin to our arch/blackfin/include/asm.
$arch/include/asm/ and $arch/asm/ would work the same. just tweak the actual -I path. -mike
| |