lkml.org 
[lkml]   [2008]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Re: [PATCH] Breaks the redundant loop in kernel/marker.c

    * Zhaolei <zhaolei@cn.fujitsu.com> wrote:

    > Ingo Molnar wrote:
    > > hm, could you describe the necessity of this patch some more? This has
    > > the change to change behavior, which might even be a bugfix: is there
    > > any chance that the closure-loop in the e->ptype != NULL branch does not
    > > exit? Before your patch we'd continue the iteration - which _probably_
    > > does not lead to any more matches (e->name is supposed to be unique).
    >
    > Because e->name is unique in list, we don't need to continue the iteration
    > after matched.
    > This is a cleanup.

    ok - it's useful to point this out in the changelog. You can use the
    "Impact:" header we started using recently:

    Impact: cleanup, no functionality changed

    See for example this upstream commit:

    | commit 07454bfff151d2465ada809bbaddf3548cc1097c
    | Author: Thomas Gleixner <tglx@linutronix.de>
    | Date: Sat Oct 4 10:51:07 2008 +0200
    |
    | clockevents: check broadcast tick device not the clock events device
    |
    | Impact: jiffies increment too fast.

    Mathieu, any objections against the patch?

    Ingo


    \
     
     \ /
      Last update: 2008-10-20 09:27    [W:0.023 / U:0.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site