Messages in this thread | | | Date | Mon, 20 Oct 2008 09:25:20 +0200 | From | Ingo Molnar <> | Subject | Re: Re: [PATCH] Breaks the redundant loop in kernel/marker.c |
| |
* Zhaolei <zhaolei@cn.fujitsu.com> wrote:
> Ingo Molnar wrote: > > hm, could you describe the necessity of this patch some more? This has > > the change to change behavior, which might even be a bugfix: is there > > any chance that the closure-loop in the e->ptype != NULL branch does not > > exit? Before your patch we'd continue the iteration - which _probably_ > > does not lead to any more matches (e->name is supposed to be unique). > > Because e->name is unique in list, we don't need to continue the iteration > after matched. > This is a cleanup.
ok - it's useful to point this out in the changelog. You can use the "Impact:" header we started using recently:
Impact: cleanup, no functionality changed
See for example this upstream commit:
| commit 07454bfff151d2465ada809bbaddf3548cc1097c | Author: Thomas Gleixner <tglx@linutronix.de> | Date: Sat Oct 4 10:51:07 2008 +0200 | | clockevents: check broadcast tick device not the clock events device | | Impact: jiffies increment too fast.
Mathieu, any objections against the patch?
Ingo
| |