Messages in this thread Patch in this message | | | Date | Mon, 20 Oct 2008 09:12:03 +0200 | From | Ingo Molnar <> | Subject | [PATCH] x86, ioremap: use %pR in printk |
| |
* Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> This converts things in drivers/pci to use %pR to printout the > content of a struct resource instead of hand-casted %llx or > other variants. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
cool!
Acked-by: Ingo Molnar <mingo@elte.hu>
there's also two places in arch/x86/mm/ioremap.c that could use this straight away - see the (untested) patch below.
Ingo
---------------------> From 3b4f8fd4ff54a2da035e972a610b8d5ac8d8eabb Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Mon, 20 Oct 2008 09:08:57 +0200 Subject: [PATCH] x86, ioremap: use %pR in printk
use the new %pR IO resource pointer/address/size printk type conversion specifier.
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- arch/x86/mm/ioremap.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c index ae71e11..640c653 100644 --- a/arch/x86/mm/ioremap.c +++ b/arch/x86/mm/ioremap.c @@ -207,8 +207,8 @@ static void __iomem *__ioremap_caller(resource_size_t phys_addr, return NULL; if (!phys_addr_valid(phys_addr)) { - printk(KERN_WARNING "ioremap: invalid physical address %llx\n", - (unsigned long long)phys_addr); + printk(KERN_WARNING "ioremap: invalid physical address %pR\n", + phys_addr); WARN_ON_ONCE(1); return NULL; } @@ -267,9 +267,9 @@ static void __iomem *__ioremap_caller(resource_size_t phys_addr, (prot_val == _PAGE_CACHE_WC && new_prot_val == _PAGE_CACHE_WB)) { pr_debug( - "ioremap error for 0x%llx-0x%llx, requested 0x%lx, got 0x%lx\n", - (unsigned long long)phys_addr, - (unsigned long long)(phys_addr + size), + "ioremap error for %pR-%pR, requested 0x%lx, got 0x%lx\n", + phys_addr, + phys_addr + size, prot_val, new_prot_val); free_memtype(phys_addr, phys_addr + size); return NULL;
| |