lkml.org 
[lkml]   [2008]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] add additional symbols to /sys/kernel/vmcoreinfo data for ppc(64)
    On Sun, Oct 19, 2008 at 08:28:05PM -0400, Neil Horman wrote:
    > Hey Vivek, as promised, a corrected patch
    >
    > The makdumpdile dump filtering program, in some modes of operation needs
    > the node_data and/or contig_page_data symbols to function properly. These
    > symbols are missing from the powerpc kernel. This patch adds those symbols in
    > properly. Tested successfully by myself and the reporter.
    >
    > Regards
    > Neil
    >
    > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
    >
    >
    > machine_kexec.c | 8 ++++++++
    > 1 file changed, 8 insertions(+)
    >
    >
    > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
    > index aab7688..5d51e75 100644
    > --- a/arch/powerpc/kernel/machine_kexec.c
    > +++ b/arch/powerpc/kernel/machine_kexec.c
    > @@ -44,6 +44,14 @@ void machine_kexec_cleanup(struct kimage *image)
    > ppc_md.machine_kexec_cleanup(image);
    > }
    >
    > +void arch_crash_save_vmcoreinfo(void)
    > +{
    > +#ifdef CONFIG_NEED_MULTIPLE_NODES
    > + VMCOREINFO_SYMBOL(node_data);
    > + VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
    > +#endif
    > +}
    > +

    Looks good to me.

    Acked-by: Vivek Goyal <vgoyal@redhat.com>

    Thanks
    Vivek


    \
     
     \ /
      Last update: 2008-10-20 14:55    [W:0.555 / U:30.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site