Messages in this thread | | | Subject | Re: [PATCH] x86, ioremap: use %pR in printk | From | Benjamin Herrenschmidt <> | Date | Mon, 20 Oct 2008 22:22:48 +1100 |
| |
On Mon, 2008-10-20 at 22:15 +1100, Benjamin Herrenschmidt wrote: > > so how about something like the two patches below (ontop of Linus's > > patch): the first patch introduces a "small" resource pointer printout > > format: %pr - the little brother of %pR. > > > > The output format is [0x00001234] - minimum width is 8. > > > > The second patch takes advantage of it in ioremap.c. > > Well, I did the exact same patch except I used the same function > and just added a flag for "R" vs. "r". However, I didn't post it > because I wasn't too happy with passing by pointer and I wasn't > sure whether we wanted to keep the letter after p uppercase or not... In > any case, I kept it as a thing to discuss after the first one goes in. > > At this stage, I'm tempted to go for a %pP for printing a pointer to > a phys_addr_t (and that's the same as resource_size_t, just more generic > nowadays, since those were consolidated). > > Still not too happy with the pointer thing but that's the best we can > do I suppose without losing gcc type checking.
Oh, and I didn't like having the brackets around something that isn't a range too but that's a minor details.
Ben.
| |