lkml.org 
[lkml]   [2008]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm: unify shmem and tiny-shmem
Date
From
Hugh Dickins <hugh@veritas.com> wrote:

> That's much nicer than I'd been imagining, thanks Matt: I've no qualms
> about the few #ifdefs you're adding to mm/shmem.c, it does seem an
> outright improvement that you're bringing them together.

It's not an outright improvement. shmem.o is still larger than tiny-shmem.o,
albeit not a lot; however, some embedded people really do count the bytes.

> This ifndef is the ugliest part of it: and looking into it, guess
> what, shmem_get_unmapped_area() hasn't been used since 2.6.20 -
> that's right, isn't it, David?

Ummm... It seems to be. I think it used to be used by SYSV SHM. Certainly
deleting that function causes no link problems.

David


\
 
 \ /
  Last update: 2008-10-03 00:27    [W:0.051 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site