lkml.org 
[lkml]   [2008]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: w35und wifi driver for linux-staging
From
Date
On Wed, 2008-10-01 at 08:52 -0400, Christoph Hellwig wrote:
> On Wed, Oct 01, 2008 at 02:36:56PM +0200, Pavel Machek wrote:
> > +source "drivers/net/wireless/winbond/Kconfig"
>
> winbond is a little too generic, please use the same name as the driver
> name for the directory.
>
> > @@ -0,0 +1,6 @@
> > +config W35UND
> > + tristate "Winbond driver"
> > + depends on MAC80211 && WLAN_80211 && EXPERIMENTAL && !4KSTACKS
> > + ---help---
> > + This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
> > + Check http://code.google.com/p/winbondport/ for new version
>
> Again, please give the option a useful name, and a useful description
> including mentioning the actual chip name in there.
>
> Also the !4KSTACKS dependency looks rather odd.

Whatever in the driver uses lots of stack space needs to be fixed, plain
an simple... no excuse for that.

Dan

> > diff --git a/drivers/net/wireless/winbond/Makefile b/drivers/net/wireless/winbond/Makefile
> > new file mode 100644
> > index 0000000..4682dd1
> > --- /dev/null
> > +++ b/drivers/net/wireless/winbond/Makefile
> > @@ -0,0 +1,17 @@
> > + BASE_DIR=./winbondport
> > + DRIVER_DIR=./winbondport/linux
> > +
> > +obj-m := w35und.o
> > +
> > +w35und-objs := $(DRIVER_DIR)/wbusb.o $(DRIVER_DIR)/wb35reg.o $(DRIVER_DIR)/wb35rx.o $(DRIVER_DIR)/wb35tx.o \
> > + $(BASE_DIR)/mds.o \
> > + $(BASE_DIR)/mlmetxrx.o \
> > + $(BASE_DIR)/mto.o $(BASE_DIR)/phy_calibration.o $(BASE_DIR)/reg.o \
> > + $(BASE_DIR)/rxisr.o \
> > + $(BASE_DIR)/sme_api.o $(BASE_DIR)/wbhal.o $(BASE_DIR)/wblinux.o \
> > +
> > +
> > +obj-$(CONFIG_W35UND) += w35und.o
>
> This is not a proper Makefile, and having these files in subdirectories
> is not really a good idea either. So move all files into one directory
> and write a proper Makefile for it:
>
> w35und-y += wbusb.o wb35reg.o wb35rx.o wb35tx.o mds.o mlmetxrx.o \
> mto.o phy_calibration.o reg.o rxisr.o sme_api.o wbhal.o \
> wblinux.o
>
> obj-$(CONFIG_W35UND) += w35und.o
>
> > diff --git a/drivers/net/wireless/winbond/winbondport/Makefile b/drivers/net/wireless/winbond/winbondport/Makefile
> > new file mode 100644
> > index 0000000..b03564c
> > --- /dev/null
> > +++ b/drivers/net/wireless/winbond/winbondport/Makefile
> > @@ -0,0 +1,5 @@
> > +#
> > +# Makefile for the Winbond wireless networking driver
> > +#
> > +
> > +include $(TOPDIR)/Rules.make
>
> This looks like some 2.4 leftover.
>
> > diff --git a/drivers/net/wireless/winbond/winbondport/SVN_CHANGELOG b/drivers/net/wireless/winbond/winbondport/SVN_CHANGELOG
> > new file mode 100644
>
> should not be in the git tree.
>
> > +++ b/drivers/net/wireless/winbond/winbondport/VersionNote.txt
>
> neither.
>
>
> No comments on the code now, I don't think I want to look at it..
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html



\
 
 \ /
  Last update: 2008-10-02 21:15    [from the cache]
©2003-2011 Jasper Spaans