Messages in this thread | | | Date | Thu, 2 Oct 2008 19:07:10 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 5/7] block: Find bio sector offset given idx and offset |
| |
On Wed, Oct 01 2008, Martin K. Petersen wrote: > >>>>> "Jens" == Jens Axboe <jens.axboe@oracle.com> writes: > > Jens> Too may BUG's there, me thinks, and the interface looks > Jens> fragile. What if the bio is alreday done (bi_idx == bi_vcnt)? > > Good point! Obviously I've only used the function for bio splitting > and not at completion time. Updated patch below. > > > block: Find bio sector offset given idx and offset > > Helper function to find the sector offset in a bio given bvec index > and page offset.
Looks good, I've applied patches 1-5.
-- Jens Axboe
| |