lkml.org 
[lkml]   [2008]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] powerpc: Fix boot hang regression on MPC8544DS
    Commit 00c5372d37a78990c1530184a9c792ee60a30067 caused the MPC8544DS
    board to hang at boot. The MPC8544DS is unique in that it doesn't use
    the PCI slots on the ULI (unlike the MPC8572DS or MPC8610HPCD). So
    the dummy read at the end of the address space causes us to hang.

    We can detect the situation by comparing the bridge's BARs versus
    the root complex.

    Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
    ---

    This is a fix for 2.6.27 and is also available at:

    master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for-2.6.27

    - k

    arch/powerpc/platforms/fsl_uli1575.c | 12 +++++++++++-
    1 files changed, 11 insertions(+), 1 deletions(-)

    diff --git a/arch/powerpc/platforms/fsl_uli1575.c b/arch/powerpc/platforms/fsl_uli1575.c
    index ef74a07..8c61996 100644
    --- a/arch/powerpc/platforms/fsl_uli1575.c
    +++ b/arch/powerpc/platforms/fsl_uli1575.c
    @@ -219,11 +219,21 @@ static void __devinit quirk_final_uli5249(struct pci_dev *dev)
    int i;
    u8 *dummy;
    struct pci_bus *bus = dev->bus;
    + resource_size_t end = 0;
    +
    + for (i = PCI_BRIDGE_RESOURCES; i < PCI_BRIDGE_RESOURCES+3; i++) {
    + unsigned long flags = pci_resource_flags(dev, i);
    + if ((flags & (IORESOURCE_MEM|IORESOURCE_PREFETCH)) == IORESOURCE_MEM)
    + end = pci_resource_end(dev, i);
    + }

    for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) {
    if ((bus->resource[i]) &&
    (bus->resource[i]->flags & IORESOURCE_MEM)) {
    - dummy = ioremap(bus->resource[i]->end - 3, 0x4);
    + if (bus->resource[i]->end == end)
    + dummy = ioremap(bus->resource[i]->start, 0x4);
    + else
    + dummy = ioremap(bus->resource[i]->end - 3, 0x4);
    if (dummy) {
    in_8(dummy);
    iounmap(dummy);
    --
    1.5.5.1


    \
     
     \ /
      Last update: 2008-10-02 08:07    [W:3.333 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site