lkml.org 
[lkml]   [2008]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3] Add SPI over GPIO driver
    Date
    On Friday 17 October 2008 05:14:26 Magnus Damm wrote:
    > On Mon, Jul 21, 2008 at 4:46 AM, Michael Buesch <mb@bu3sch.de> wrote:
    > > This adds a driver that lets you drive an SPI bus over
    > > generic GPIO pins.
    > >
    > > Signed-off-by: Michael Buesch <mb@bu3sch.de>
    >
    > Very useful. Fits my shiny new GPIO implementation for SuperH like a glove.
    >
    > Michael, as you know, I have some SuperH board code that makes use of
    > this driver. Are there any outstanding issues with this driver that I
    > can help resolving?

    bool cs_activelow should probably be removed from struct spi_gpio_platform_data.

    I think cs always is activelow, so we can simply hardcode this in spi_gpio_chipselect()

    If you want to do this, please feel free to do so.
    I currently don't have the time for this.
    The rest of the driver is fine with me.

    --
    Greetings Michael.


    \
     
     \ /
      Last update: 2008-10-17 10:55    [W:0.033 / U:60.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site