lkml.org 
[lkml]   [2008]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 5/7] of/gpio: implement of_dev_gpiochip_{add,remove} calls
    Date
    On Thursday 16 October 2008, Anton Vorontsov wrote:
    > +       if (of_gc->chip)
    > +               return of_gc->chip;
    > +       return &of_gc->gc;

    presumably there's a reason not to

    of_gc->chip = &of_gc->gc;

    when this gets set up, so this can always be a simple

    return of_gc->chip;

    (and inlined)? Needlessly complex...


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-10-17 22:35    [W:0.052 / U:29.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site