Messages in this thread | | | Date | Fri, 17 Oct 2008 12:23:39 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [RFC patch 07/15] LTTng timestamp |
| |
* KOSAKI Motohiro (kosaki.motohiro@jp.fujitsu.com) wrote: > > more nit. > > > +#include <linux/module.h> > > +#include <linux/init.h> > > +#include <linux/delay.h> > > +#include <linux/timer.h> > > +#include <linux/workqueue.h> > > +#include <linux/cpu.h> > > +#include <linux/timex.h> > > +#include <linux/bitops.h> > > +#include <linux/ltt.h> > > ltt.h is created by 08/15. then following build error happend. > > make[1]: `include/asm-ia64/nr-irqs.h' is up to date. > CHK include/linux/version.h > CHK include/linux/utsrelease.h > CALL scripts/checksyscalls.sh > CHK include/linux/compile.h > GZIP kernel/config_data.gz > IKCFG kernel/config_data.h > CC kernel/configs.o > LD kernel/built-in.o > CC ltt/ltt-timestamp.o > ltt/ltt-timestamp.c:23:23: error: linux/ltt.h: No such file or directory > ltt/ltt-timestamp.c: In function 'ltt_update_synthetic_tsc': > ltt/ltt-timestamp.c:75: error: implicit declaration of function 'ltt_get_timestamp32' > ltt/ltt-timestamp.c: In function 'precalc_stsc_interval': > ltt/ltt-timestamp.c:157: error: implicit declaration of function 'ltt_frequency' > ltt/ltt-timestamp.c:157: error: implicit declaration of function 'ltt_freq_scale' > make[1]: *** [ltt/ltt-timestamp.o] Error 1 > make: *** [ltt] Error 2 >
Thanks for pointing this out. Will fix in the next release with the following patchset order :
get-cycles-kconfig-have-get-cycles.patch get-cycles-x86-have-get-cycles.patch get-cycles-sparc64-have-get-cycles.patch get-cycles-powerpc-have-get-cycles.patch get-cycles-mips-have-get-cycles.patch
#LTTng timestamping # lttng-timestamp-core.patch lttng-timestamp-generic.patch lttng-build-instrumentation-menu.patch lttng-build-instrumentation-menu-timestamp.patch lttng-mips-export-hpt-frequency.patch lttng-timestamp-mips.patch lttng-timestamp-powerpc.patch lttng-timestamp-sparc64.patch lttng-timestamp-sh.patch lttng-test-tsc.patch lttng-timestamp-x86.patch
Mathieu
> > > +#include <linux/smp.h> > > +#include <linux/sched.h> /* FIX for m68k local_irq_enable in on_each_cpu */ > > > >
-- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
| |