lkml.org 
[lkml]   [2008]   [Oct]   [17]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 16 Oct 2008 22:21:08 -0700 (PDT)
SubjectRe: [PATCH] Fix broken debug output reserve_region_with_split()
FromDavid Miller <>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 16 Oct 2008 21:18:08 -0700 (PDT)

> I dunno. I'd certainly be perfectly happy with having the flags and 
> field_width be specified by the resource flags. eg
> 
> 	flags = ZEROPAD | SMALL;
> 	fieldwidth = (res->flags & IORESOURCE_IO) ? 4 : 8;
> 
> or something like that. But would it be acceptable to everybody?

I personally appreciate seeing the full 64-bit address on sparc64,
even for IORESOURCE_IO, and that's helped me debug resource
calculation bugs on more than one occasion in the past.

But that's just me :)


\
 
 \ /
  Last update: 2008-10-17 07:23    [from the cache]
©2003-2008