lkml.org 
[lkml]   [2008]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] stop gcc warning about uninitialized 'dev' in ata_scsi_scan_host
* Adrian Bunk <bunk@kernel.org>:
> On Wed, Oct 15, 2008 at 09:40:42PM -0600, Alex Chiang wrote:
> > * Tejun Heo <tj@kernel.org>:
> > > Alex Chiang wrote:
> > > > Shuts up gcc-3.4.5-glibc-2.3.6 when it complains of:
> > > >
> > > > drivers/ata/libata-scsi.c: In function `ata_scsi_scan_host':
> > > > drivers/ata/libata-scsi.c:3225: warning: 'dev' might be used
> > > > uninitialized in this function
> > > >
> > > > Signed-off-by: Alex Chiang <achiang@hp.com>
> > >
> > > Nacked-by: Tejun Heo <tj@kernel.org>
> > >
> > > Some gcc versions complain about sata_via, others complain
> > > about something else. Some versions complain about some
> > > iterator usages while not complaining about others, but none of
> > > those complaints is actually wrong or dangerous. I don't think
> > > adding = NULL whenever some version of gcc complains is the
> > > right approach.
> >
> > Hm, ok.
> >
> > I guess we don't want to sprinkle these around all over the place
> > just to solve cosmetic issues, which makes sense, but is there
> > some other approach we could take instead? Any suggestions? Or
> > just live with it?
>
> We have an annotation for these kinds of warnings in the kernel.

What is the annotation?

> But we'll never get a warning-free compilation with all seven (sic)
> supported gcc release series.
>
> A warning-free compilation with gcc 4.3 is worth some efforts, but
> cluttering our code to fix bogus warnings with older gcc versions
> is not a good thing.

Ok, I already agree with this point.

Thanks.

/ac



\
 
 \ /
  Last update: 2008-10-16 23:23    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site