Messages in this thread | | | Date | Thu, 16 Oct 2008 12:25:02 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] Add support for Dallas DS28CM00 Unique ID chip |
| |
On Tue, 07 Oct 2008 14:09:59 +0100 Mark Jackson <mpfj@mimc.co.uk> wrote:
> This patch adds support for the (I2C based) DS28CM00 ID chip.
Please run scritps/checkpatch.pl across the diff and consider the various things which it reports. Many of them are minor layout issues. The lack of printk facility levels is a should-fix thing.
> printk("adding ds28cm00 driver !!\n");
Remove the " !!" :)
Please also cc i2c@lm-sensors.org on version 2.
Thanks.
| |