Messages in this thread |  | | | From | Rusty Russell <> | | Subject | Re: [PATCH 1/2] virtio_net: Recycle some more rx buffer pages | | Date | Thu, 16 Oct 2008 16:08:53 +1100 | |
On Thursday 09 October 2008 06:34:58 Mark McLoughlin wrote:
> Each time we re-fill the recv queue with buffers, we allocate
> one too many skbs and free it again when adding fails. We should
> recycle the pages allocated in this case.
>
> A previous version of this patch made trim_pages() trim trailing
> unused pages from skbs with some paged data, but this actually
> caused a barely measurable slowdown.
Yes, I noticed a similar effect. Not quite sure why though.
Applied.
Thanks!
Rusty.
|  |