lkml.org 
[lkml]   [2008]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] mfd: Don't use NO IRQ in WM8350
    Date
    From





    On Wed, 15 Oct 2008 11:20:54 +0100, Mark Brown

    <broonie@opensource.wolfsonmicro.com> wrote:

    > NO_IRQ is only defined on some architectures - the general way to test

    > for an invalid IRQ in the modern kernel is by comparing with zero.

    >

    > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>

    > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

    Applied, thanks.

    I'll send a pull request to Linus soon.



    Cheers,

    Samuel.





    > ---

    >

    > This is a build fix for platforms that don't define NO_IRQ (which is

    > most of them). Please merge as soon as possible.

    >

    > drivers/mfd/wm8350-core.c | 2 +-

    > 1 files changed, 1 insertions(+), 1 deletions(-)

    >

    > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c

    > index 25a7a5d..bf87f67 100644

    > --- a/drivers/mfd/wm8350-core.c

    > +++ b/drivers/mfd/wm8350-core.c

    > @@ -1217,7 +1217,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int

    > irq,

    >

    > mutex_init(&wm8350->irq_mutex);

    > INIT_WORK(&wm8350->irq_work, wm8350_irq_worker);

    > - if (irq != NO_IRQ) {

    > + if (irq) {

    > ret = request_irq(irq, wm8350_irq, 0,

    > "wm8350", wm8350);

    > if (ret != 0) {

    >


    \
     
     \ /
      Last update: 2008-10-15 13:57    [W:0.039 / U:92.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site