Messages in this thread |  | | | Date | Wed, 15 Oct 2008 09:50:45 +0200 (CEST) | | From | Geert Uytterhoeven <> | | Subject | Re: [patch 17/18] net/rfkill/rfkill-input.c needs <linux/sched.h> |
| |
On Wed, 15 Oct 2008, Henrique de Moraes Holschuh wrote: > On Tue, 14 Oct 2008, Geert Uytterhoeven wrote: > > Unfortunately that's not possible, due to Include Hell(tm). > > Therefore, including <linux/sched.h> is the way this has been fixed in > > the past. > > I see. Well, when doing this I'd suggest adding a comment, otherwise the > include could end up getting removed sooner or later without anyone asking > linux-m68k first (I seriously douby anyone will do git blame to find out why > an #include line exists before removing it). > > Something like: > #include <sched.h> /* m68k needs task_struct for <whatever> */
Probably we should start looking again into extracting struct task_struct into its own header file, cfr. what Roman Zippel did a long time ago...
Gr{oetje,eeting}s, Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |