Messages in this thread | | | Date | Wed, 15 Oct 2008 10:17:27 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [2.6 patch] HID: fix default building of all quirky devices |
| |
On Wed, 15 Oct 2008, Linus Torvalds wrote: > > And notice how you mis-use select. That's not how to disable a question. A > question gets disabled by just doing an "if xyz" on the question itself, > like Adrian did.
Side note: Adrian too has a very odd and non-obvious way of doing this.
His patch did config entries like
config HID_BRIGHT tristate "Bright" if EMBEDDED default USB_HID depends on USB_HID
which is a really odd way to express this. The much more natural one is
config HID_BRIGHT tristate "Bright" if EMBEDDED depends on USB_HID default y
since there's no point in saying "default USB_HID" + "depends on USB_HID", and that's just confusing. Since it depends on USB_HID, the "default y" will automatically degrade to whatever USB_HID was set to.
Linus
| |