[lkml]   [2008]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: GIT head no longer boots on x86-64

    On Wed, 15 Oct 2008, Jiri Slaby wrote:
    > Users usually do
    > is_vmalloc_addr(a) ? vfree(a) : kfree(a);
    > Even there it makes more sense to me.

    Umm. No it doesn't.

    That is exactly _wh7y_ "is_vmalloc_addr()" exists. But we sure as hell
    don't ever want to trigger on modules for that.

    If you think that "is_vmalloc_addr()" should trigger for any kernel
    virtual address, why not just make it do so, then? And _name_ it so.

    Names are important. In fact, naming is often _more_ important than the
    implementation is. And that means that the implementation should follow
    the naming, or the implementation is wrong.


     \ /
      Last update: 2008-10-15 18:05    [W:0.020 / U:7.132 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site