Messages in this thread | | | Date | Tue, 14 Oct 2008 09:23:42 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [patch 17/18] net/rfkill/rfkill-input.c needs <linux/sched.h> |
| |
On Mon, 13 Oct 2008, Henrique de Moraes Holschuh wrote: > On Mon, 13 Oct 2008, Geert Uytterhoeven wrote: > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > > For some m68k configs, I get: > > > > | net/rfkill/rfkill-input.c: In function 'rfkill_start': > > | net/rfkill/rfkill-input.c:208: error: dereferencing pointer to incomplete type > > > > As the incomplete type is `struct task_struct', including <linux/sched.h> fixes > > it. > > Line 208 is this (in latest Linus mainline and also v2.6.27): > > spin_unlock_irq(&handle->dev->event_lock); > > So we need to include sched.h to everything that uses spin_unlock_irq? If > only some variants of m68k need that, shouldn't it have been added on the > header that defines spin_unlock_irq() on those arches, instead?
Unfortunately that's not possible, due to Include Hell(tm). Therefore, including <linux/sched.h> is the way this has been fixed in the past.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |