lkml.org 
[lkml]   [2008]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PATCH] intermediate SCSI updates


On Mon, 13 Oct 2008, James Bottomley wrote:
>
> This represents all the pieces of SCSI which were depending on the
> already merged block tree.

Grr. And it doesn't actually compile.

drivers/scsi/sd.c:579:27: error: macro "sd_dif_op" passed 4 arguments, but takes just 3
drivers/scsi/sd.c: In function ‘sd_prep_fn’:
drivers/scsi/sd.c:578: error: ‘sd_dif_op’ undeclared (first use in this function)
drivers/scsi/sd.c:578: error: (Each undeclared identifier is reported only once
drivers/scsi/sd.c:578: error: for each function it appears in.)

Hmm? Was this testedt AT ALL? It can never compile unless that idiotic
CONFIG_BLK_DEV_INTEGRITY option is set that no sane person would set right
now, and which is even documented to not be enabled by default:

If in doubt, say N.

yet it looks like it has not compiled since a commit that was put in in
the middle of September!

What part of "This is total untested crap" are we missing here?

Yeah, I'm grumpy. I expect to not be fed shit like this. It has apparently
been rebased several times, and all apparently with no testing
what-so-ever!

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-10-13 19:25    [W:1.470 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site