Messages in this thread | | | From | Kumar Gala <> | Subject | Re: [PATCH] powerpc: fix fsl_upm nand driver modular build | Date | Mon, 13 Oct 2008 11:48:38 -0500 |
| |
On Oct 8, 2008, at 7:32 PM, Anton Vorontsov wrote:
> The fsl_upm nand driver fails to build because fsl_lbc_lock isn't > exported, the lock is needed by the inlined fsl_upm_run_pattern() > function: > > ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined! > > Dave Jones purposed to export the lock, but it is better to just > uninline > the fsl_upm_run_pattern(). > > When uninlined we also no longer need the exported fsl_lbc_regs, and > both fsl_lbc_lock and fsl_lbc_regs could be marked static. > > While at it, also add some missing includes that we should have > included > explicitly. > > Reported-by: Dave Jones <davej@redhat.com> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > ---
applied.
- k
| |