lkml.org 
[lkml]   [2008]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fastboot: Introduce an asynchronous function call mechanism
On Mon, 13 Oct 2008 10:15:03 +0300
"Pekka Enberg" <penberg@cs.helsinki.fi> wrote:

> Hi Arjan,
>
> On Mon, Oct 13, 2008 at 2:44 AM, Arjan van de Ven
> <arjan@infradead.org> wrote:
> > +void call_async(int pool_number, int argc, ...)
> > +{
> > + struct async_item *item;
> > + va_list ap;
> > +
> > + if (argc > 4 || argc < 0) {
> > + WARN(1, KERN_ERR "Too many arguments to async
> > function! Skipping...\n");
> > + return;
> > + }
> > +
> > + item = kmalloc(sizeof(struct async_item), GFP_ATOMIC);
>
> Why is there no check for NULL here?


because at 35000 feet it won't return NULL ;-)

but yeah thanks for spotting, I'll fix it.

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2008-10-13 16:47    [W:0.170 / U:0.376 seconds]
©2003-2014 Jasper Spaans. Advertise on this site