lkml.org 
[lkml]   [2008]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: SLUB defrag pull request?
    From
    Date
    On Mon, 13 Oct 2008, Christoph Lameter wrote:
    > Miklos Szeredi wrote:
    > > I think it's wrong to unhash dentries while they are possibly still
    > > being used. You can do the shrink_dcache_parent() here, but should
    > > leave the unhashing to be done by prune_one_dentry(), after it's been
    > > checked that there are no other users of the dentry.
    > >
    > >
    > d_invalidate() calls shrink_dcache_parent() as needed and will fail if
    > there are other users of the dentry.

    Only if it's a directory. Now unhashing an in-use non-directory is
    not fatal, but you'll get things like "filename (deleted)" in /proc,
    and suchlike. Don't do it.

    Miklos


    \
     
     \ /
      Last update: 2008-10-13 16:31    [W:0.018 / U:89.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site