lkml.org 
[lkml]   [2008]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: SLUB defrag pull request?
    From
    Date
    On Mon, 13 Oct 2008, Miklos Szeredi wrote:
    > On Mon, 13 Oct 2008, Nick Piggin wrote:
    > > In many cases, yes it seems to. And some of the approaches even if
    > > they work now seem like they *might* cause problematic constraints
    > > in the design... Have Al and Christoph reviewed the dentry and inode
    > > patches?
    >
    > This d_invalidate() looks suspicious to me:

    And the things kick_inodes() does without any sort of locking look
    even more dangerous.

    It should be the other way round: first make sure nothing is
    referencing the inode, and _then_ start cleaning it up with
    appropriate locks held. See prune_icache().

    Miklos


    \
     
     \ /
      Last update: 2008-10-13 16:29    [W:0.019 / U:0.620 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site